tustvold commented on code in PR #3180:
URL: https://github.com/apache/arrow-rs/pull/3180#discussion_r1031695898
##########
arrow/src/row/fixed.rs:
##########
@@ -266,60 +267,42 @@ pub fn decode_bool(rows: &mut [&[u8]], options:
SortOptions) -> BooleanArray {
unsafe { BooleanArray::from(builder.build_unchecked()) }
}
+fn decode_nulls(rows: &[&[u8]]) -> (usize, Buffer) {
Review Comment:
Handling the null mask separately has no discernible impact on performance,
it is possible it might actually improve it marginally, it reduces code
complexity significantly, and will help reuse this logic for the fixed length
binary array (PR to follow)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
