aucahuasi commented on PR #14287: URL: https://github.com/apache/arrow/pull/14287#issuecomment-1326895583
LGTM! For the next PRs, would be great to invest a bit to improve even more the error handling: to provide more context to the user in the case of invalid expressions. For instance, for this invalid expression: `add($duration(MILLI):10, $duration(MILLIa):20)` we get this error: `'_error_or_value82.status()' failed with Invalid: Error at index 43: Unterminated data type arg list!` it would be nice to get a more precise error message here. btw I built this on a macbook pro m1 without issues (clang compiler) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
