Ted-Jiang commented on PR #4358: URL: https://github.com/apache/arrow-datafusion/pull/4358#issuecomment-1326974073
@alamb this change to good to me! But i still have a question about when to use `error!` in datafusion 🤔? after https://github.com/apache/arrow-datafusion/commit/d7a7fb61afe9ce2824aae737f65aec12d9513f7f merged i think there should no error log in test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
