jackwener commented on code in PR #4242:
URL: https://github.com/apache/arrow-datafusion/pull/4242#discussion_r1032007065
##########
datafusion/expr/src/type_coercion/binary.rs:
##########
@@ -98,8 +98,12 @@ pub fn coerce_types(
| Operator::BitwiseShiftRight
| Operator::BitwiseShiftLeft => bitwise_coercion(lhs_type, rhs_type),
Operator::And | Operator::Or => match (lhs_type, rhs_type) {
- // logical binary boolean operators can only be evaluated in bools
+ // logical binary boolean operators can only be evaluated in bools
or nulls
(DataType::Boolean, DataType::Boolean) => Some(DataType::Boolean),
+ (DataType::Null, DataType::Null) => Some(DataType::Null),
+ (DataType::Boolean, DataType::Null) | (DataType::Null,
DataType::Boolean) => {
+ Some(DataType::Boolean)
Review Comment:
Here exist some problem.
true And Null -> Null
false Or Null -> Null
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
