liyafan82 commented on a change in pull request #8475:
URL: https://github.com/apache/arrow/pull/8475#discussion_r506046740
##########
File path:
java/vector/src/main/codegen/templates/AbstractPromotableFieldWriter.java
##########
@@ -106,6 +106,28 @@ public void writeBigEndianBytesToDecimal(byte[] value,
ArrowType arrowType) {
public void writeBigEndianBytesToDecimal(byte[] value) {
getWriter(MinorType.DECIMAL).writeBigEndianBytesToDecimal(value);
}
+ <#elseif minor.class == "BigDecimal">
+ @Override
+ public void write(BigDecimalHolder holder) {
+ getWriter(MinorType.BIGDECIMAL).write(holder);
+ }
+
+ public void writeBigDecimal(int start, ArrowBuf buffer, ArrowType arrowType)
{
+ getWriter(MinorType.BIGDECIMAL).writeBigDecimal(start, buffer, arrowType);
+ }
+
+ public void writeBigDecimal(int start, ArrowBuf buffer) {
Review comment:
The type of `start` should be long, as it represents the start offset in
the ArrowBuf, just like in https://github.com/apache/arrow/pull/8455
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
