jackwener commented on code in PR #4373:
URL: https://github.com/apache/arrow-datafusion/pull/4373#discussion_r1032785466
##########
datafusion/sql/src/planner.rs:
##########
@@ -767,7 +767,8 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
let join_filter = filter.into_iter().reduce(Expr::and);
if left_keys.is_empty() {
- // When we don't have join keys, use cross join
+ // TODO should not use cross join when the join_filter
exists
+ // https://github.com/apache/arrow-datafusion/issues/4363
Review Comment:
Perhaps our current crossjoin implementation is a little strange.
Some databases implement Crossjoin via Nest Loop Join. (cross join is
logical, NLJ is physical)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
