alamb opened a new pull request, #4382: URL: https://github.com/apache/arrow-datafusion/pull/4382
# Which issue does this PR close? re https://github.com/apache/arrow-datafusion/issues/4349 # Rationale for this change Step 1 of N in unraveling the gordian knot of datafusion configuration While there is a need to serialize/deserialize session state as key=value pairs in SessionContext, there is no reason these key / value pairs need to be kept in the actual TaskContext after it is created and having the different representation makes the eventual unification of configuration that much harder. # What changes are included in this PR? 1. Remove duplication in `From` impls 2. # Are these changes tested? covered by existing tests # Are there any user-facing changes? If you use TaskProperties directly you'll be impacted, but I don't think anyone does. It is not used by ballista https://github.com/search?q=repo%3Aapache%2Farrow-ballista%20KVPairs&type=code @mingmwang this code was originally added by you in https://github.com/apache/arrow-datafusion/pull/1987 -- can you take a look ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
