westonpace commented on code in PR #14663:
URL: https://github.com/apache/arrow/pull/14663#discussion_r1032886235
##########
cpp/src/arrow/compute/exec/expression.h:
##########
@@ -220,6 +220,8 @@ ARROW_EXPORT
Result<Expression> SimplifyWithGuarantee(Expression,
const Expression&
guaranteed_true_predicate);
+ARROW_EXPORT Result<Expression> RemoveNamedRefs(Expression expression);
Review Comment:
Added a docstring and a few basic tests (`Expression.RemoveNamedRefs`)
##########
cpp/src/arrow/compute/exec/options.h:
##########
@@ -175,6 +177,7 @@ class ARROW_EXPORT SinkNodeOptions : public ExecNodeOptions
{
/// data from the plan. If this function is not called frequently enough
then the sink
/// node will start to accumulate data and may apply backpressure.
std::function<Future<std::optional<ExecBatch>>()>* generator;
+ std::shared_ptr<Schema>* schema;
Review Comment:
Added a docstring
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
