viirya commented on code in PR #3198:
URL: https://github.com/apache/arrow-rs/pull/3198#discussion_r1033004364
##########
arrow-data/src/equal/primitive.rs:
##########
@@ -15,13 +15,17 @@
// specific language governing permissions and limitations
// under the License.
+use crate::contains_nulls;
+use arrow_buffer::bit_util::get_bit;
use std::mem::size_of;
-use crate::data::{contains_nulls, ArrayData};
-use arrow_buffer::bit_util::get_bit;
+use crate::data::ArrayData;
+use crate::slices_iterator::SlicesIterator;
use super::utils::equal_len;
+pub(crate) const NULL_SLICES_SELECTIVITY_THRESHOLD: f64 = 0.4;
Review Comment:
It came from benchmarking. `equal_nulls_512` has 0.5 null density, and this
doesn't improve it. So I pick 0.4 as the threshold.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
