jackwener commented on issue #4267: URL: https://github.com/apache/arrow-datafusion/issues/4267#issuecomment-1329338179
> I think it depends on what the global-state is. If the global states are predicates or something related to Column/Exprs, then we should remove such kind of global states.. But for some optimization rules, it might be better to keep a global state so that it is easily to figure out a best plan. Agree it, `global-state` of all rules that I change is related `Column/Exprs` or `limit number`. > I think today in DataFusion's logical optimizer rules, most of the complexity comes from dealing with predicates. Agree, especially for rule about projection/filter. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
