avantgardnerio commented on code in PR #3207: URL: https://github.com/apache/arrow-rs/pull/3207#discussion_r1033747804
########## arrow-flight/src/sql/client.rs: ########## @@ -0,0 +1,561 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +use std::collections::HashMap; +use std::sync::Arc; +use std::time::Duration; + +use crate::flight_service_client::FlightServiceClient; +use crate::sql::server::{CLOSE_PREPARED_STATEMENT, CREATE_PREPARED_STATEMENT}; +use crate::sql::{ + ActionClosePreparedStatementRequest, ActionCreatePreparedStatementRequest, + ActionCreatePreparedStatementResult, CommandGetCatalogs, CommandGetCrossReference, + CommandGetDbSchemas, CommandGetExportedKeys, CommandGetImportedKeys, + CommandGetPrimaryKeys, CommandGetSqlInfo, CommandGetTableTypes, CommandGetTables, + CommandPreparedStatementQuery, CommandStatementQuery, CommandStatementUpdate, + DoPutUpdateResult, ProstAnyExt, ProstMessageExt, SqlInfo, +}; +use crate::{ + Action, FlightData, FlightDescriptor, FlightInfo, HandshakeRequest, + HandshakeResponse, IpcMessage, Ticket, +}; +use arrow_array::RecordBatch; +use arrow_buffer::Buffer; +use arrow_ipc::convert::fb_to_schema; +use arrow_ipc::reader::read_record_batch; +use arrow_ipc::{root_as_message, size_prefixed_root_as_message, MessageHeader}; +use arrow_schema::{ArrowError, Schema, SchemaRef}; +use futures::{stream, TryStreamExt}; +use prost::Message; +use tokio::sync::{Mutex, MutexGuard}; +use tonic::transport::{Channel, Endpoint}; +use tonic::Streaming; + +/// A FlightSQLServiceClient is an endpoint for retrieving or storing Arrow data +/// by FlightSQL protocol. +#[derive(Debug, Clone)] +pub struct FlightSqlServiceClient { + token: Option<String>, + flight_client: Arc<Mutex<FlightServiceClient<Channel>>>, +} + +impl FlightSqlServiceClient { + pub async fn new_with_ep(host: &str, port: u16) -> Result<Self, ArrowError> { + let addr = format!("http://{}:{}";, host, port); + let endpoint = Endpoint::new(addr) + .map_err(|_| ArrowError::IoError("Cannot create endpoint".to_string()))? + .connect_timeout(Duration::from_secs(20)) Review Comment: I don't know why they are there, TBH. This code appears to have been copy & pasted from Ballista. I'd suggest we remove them and accept the defaults here and let users call `new(channel)` if they need extra configuration customization. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
