tustvold commented on code in PR #3205:
URL: https://github.com/apache/arrow-rs/pull/3205#discussion_r1033776747
##########
arrow-array/src/builder/map_builder.rs:
##########
@@ -286,8 +286,8 @@ mod tests {
let string_builder = builder.keys();
string_builder.append_value("joe");
- string_builder.append_null();
- string_builder.append_null();
+ string_builder.append_value("n1");
Review Comment:
We should probably add an error to MapArrayBuilder so that it returns a
meaningful error if you try to create a keys array with nulls. I believe this
may overlap somewhat with https://github.com/apache/arrow-rs/issues/1697
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
