benibus commented on PR #14753: URL: https://github.com/apache/arrow/pull/14753#issuecomment-1329662643
Not sure if there are any strong opinions about the inline functions in `vector_sort_internal.h`... Some of the definitions could remain where they were if necessary. Also, I removed a bunch of redundant `#include`s in the implementations - although I don't really know if they were just cruft or meant to prevent future breakages, as quite a few things are being implicitly pulled in by two headers. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
