paleolimbot commented on code in PR #77:
URL: https://github.com/apache/arrow-nanoarrow/pull/77#discussion_r1034036107
##########
src/nanoarrow/array_inline.h:
##########
@@ -303,10 +303,10 @@ static inline ArrowErrorCode
ArrowArrayAppendDouble(struct ArrowArray* array,
case NANOARROW_TYPE_DOUBLE:
NANOARROW_RETURN_NOT_OK(ArrowBufferAppend(data_buffer, &value,
sizeof(double)));
break;
- case NANOARROW_TYPE_FLOAT:
- _NANOARROW_CHECK_RANGE(value, FLT_MIN, FLT_MAX);
- NANOARROW_RETURN_NOT_OK(ArrowBufferAppendFloat(data_buffer, value));
+ case NANOARROW_TYPE_FLOAT: {
+ NANOARROW_RETURN_NOT_OK(ArrowBufferAppendFloat(data_buffer,
(float)value));
break;
+ }
Review Comment:
```suggestion
case NANOARROW_TYPE_FLOAT:
NANOARROW_RETURN_NOT_OK(ArrowBufferAppendFloat(data_buffer,
(float)value));
break;
```
(Feel free to revert, just a bit out of place with the other cases here)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
