frederickjansen commented on code in PR #14722:
URL: https://github.com/apache/arrow/pull/14722#discussion_r1034090751
##########
python/pyarrow/_csv.pyx:
##########
@@ -1337,6 +1355,17 @@ cdef class WriteOptions(_Weakrefable):
def delimiter(self, value):
deref(self.options).delimiter = _single_char(value)
+ @property
+ def quoting_style(self):
+ """
+ Quoting style for CSV writing.
Review Comment:
Done
##########
python/pyarrow/_csv.pyx:
##########
@@ -1288,20 +1301,25 @@ cdef class WriteOptions(_Weakrefable):
CSV data
delimiter : 1-character string, optional (default ",")
The character delimiting individual cells in the CSV data.
+ quoting_style : str, optional (default "needed")
+ Whether to quote values, and if so, which quoting style to use.
+ Accepted values are "needed", "all_valid", "none"
Review Comment:
Done, thanks for writing this out.
##########
python/pyarrow/_csv.pyx:
##########
@@ -1337,6 +1355,17 @@ cdef class WriteOptions(_Weakrefable):
def delimiter(self, value):
deref(self.options).delimiter = _single_char(value)
+ @property
+ def quoting_style(self):
+ """
+ Quoting style for CSV writing.
+ """
+ return deref(self.options).quoting_style
Review Comment:
It converted to `int` since that's what the C++ enums default to I think.
Fixed by doing the reverse of `unwrap_quoting_style`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
