yaqi-zhao commented on code in PR #14585:
URL: https://github.com/apache/arrow/pull/14585#discussion_r1034426336
##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -2203,6 +2206,53 @@ if(ARROW_WITH_RAPIDJSON)
endif()
endif()
+
+macro(build_qpl)
+ message(STATUS "Building QPL from source")
+ set(QPL_PREFIX "${CMAKE_CURRENT_BINARY_DIR}/qpl_ep/src/qpl_ep-install")
+ if(MSVC)
+ set(QPL_STATIC_LIB_NAME qplstatic.lib)
+ else()
+ set(QPL_STATIC_LIB_NAME libqpl.a)
+ endif()
+ set(QPL_STATIC_LIB "${QPL_PREFIX}/lib64/${QPL_STATIC_LIB_NAME}")
+ set(QPL_CMAKE_ARGS
+ ${EP_COMMON_CMAKE_ARGS}
+ -DCMAKE_BUILD_TYPE=Release
+ "-DCMAKE_INSTALL_PREFIX=${QPL_PREFIX}"
+ EXCLUDE_FROM_ALL NOT)
+
+
+ ExternalProject_Add(qpl_ep
+ ${EP_LOG_OPTIONS}
+ GIT_REPOSITORY https://github.com/intel/qpl.git
+ GIT_TAG v0.2.1
+ GIT_SUBMODULES_RECURSE TRUE
Review Comment:
There is a known issue on intel/qpl:
QPL cannot be built from direct downloadable files (.tar, .tgz) since it has
submodules which are not included to the archives by GitHub during release
creation(https://github.com/intel/qpl/releases). This will be solved on next
version.
For now, can we just use git repository to pull released code? Maybe we can
create an issue/Jira to track this problem if the code is merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
