jorisvandenbossche commented on code in PR #14729:
URL: https://github.com/apache/arrow/pull/14729#discussion_r1034608925


##########
python/pyarrow/tests/test_substrait.py:
##########
@@ -223,7 +224,11 @@ def table_provider(names):
     assert res_tb == test_table_1
 
 
[email protected]("ignore::pytest.PytestUnraisableExceptionWarning")
 def test_named_table_invalid_table_name():
+    # Warning generated from pyx which is unable to be propagated to caller
+    # ref: https://docs.pytest.org/en/6.2.x/usage.html#warning-about
+    #      -unraisable-exceptions-and-unhandled-thread-exceptions

Review Comment:
   The ignored exception is:
   
   ```
   Traceback (most recent call last):
     File 
"/home/joris/scipy/repos/arrow/python/pyarrow/tests/test_substrait.py", line 
238, in table_provider
       raise Exception("Unrecognized table name")
   Exception: Unrecognized table name
   ```
   
   which is IMO something we should fix instead (the error should be raised to 
the user)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to