jduo commented on a change in pull request #8476:
URL: https://github.com/apache/arrow/pull/8476#discussion_r506961358
##########
File path:
java/flight/flight-core/src/main/java/org/apache/arrow/flight/FlightService.java
##########
@@ -88,12 +87,15 @@ public void listFlights(Flight.Criteria criteria,
StreamObserver<Flight.FlightIn
public void doGetCustom(Flight.Ticket ticket, StreamObserver<ArrowMessage>
responseObserverSimple) {
final ServerCallStreamObserver<ArrowMessage> responseObserver =
(ServerCallStreamObserver<ArrowMessage>) responseObserverSimple;
+
final GetListener listener = new GetListener(responseObserver,
this::handleExceptionWithMiddleware);
- try {
- producer.getStream(makeContext(responseObserver), new Ticket(ticket),
listener);
- } catch (Exception ex) {
- listener.error(ex);
- }
+ executors.submit(() -> {
Review comment:
Do you mean within GetListener? We register #onReady() on the
responseObserver during GetListener's constructor, which will delegate to the
onReadyHandler if it's been set.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
