alamb commented on issue #479:
URL: https://github.com/apache/arrow-ballista/issues/479#issuecomment-1330663376

   > I'd strongly recommend removing the hashmap (if we can, do we need to 
support configuration for downstream projects?), and keeping everything compile 
time type checked.
   
   For what it is worth I think think we can still have compile time type 
checks with a HashMap implementation using a builder style API on 
SessionConfig: 
   
   
https://github.com/apache/arrow-datafusion/blob/dd3f72ad13df3e3ab2efde73eba546012eaf10fd/datafusion/core/src/execution/context.rs#L1240-L1245
   
   What do you think about a style like this @avantgardnerio ?
   
   ```rust
   let config = SessionConfig::new()
     .with_target_partitions(18)
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to