thisisnic commented on code in PR #14678: URL: https://github.com/apache/arrow/pull/14678#discussion_r1034905387
########## r/PACKAGING.md: ########## @@ -0,0 +1,121 @@ + +<!--- + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. +--> + +# Packaging checklist for CRAN release + +For a high-level overview of the release process see the +[Apache Arrow Release Management Guide](https://arrow.apache.org/docs/developers/release.html#post-release-tasks). + +- [ ] When a release candidate is created + [Create a GitHub issue](https://github.com/apache/arrow/issues/new/) + entitled `[R] CRAN release version X.X.X` and copy this checklist to the issue + +- [ ] Evaluate the status of any failing + [nightly tests and nightly packaging builds](https://lists.apache.org/[email protected]): these are run + against the master branch and not the release branch, so the results may be + slightly out of date. After the CRAN-specific release branch has been created, + we can run any or all tests again using a GitHub PR and crossbow. Review Comment: ```suggestion ``` I'm confused by this step - is this a new additional step? It's not release verification, as that's something else. Kou later made https://github.com/apache/arrow/pull/14654 which basically does everything we need to do in this step. We need more info here. ########## r/PACKAGING.md: ########## @@ -0,0 +1,121 @@ + +<!--- + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. +--> + +# Packaging checklist for CRAN release + +For a high-level overview of the release process see the +[Apache Arrow Release Management Guide](https://arrow.apache.org/docs/developers/release.html#post-release-tasks). + +- [ ] When a release candidate is created + [Create a GitHub issue](https://github.com/apache/arrow/issues/new/) + entitled `[R] CRAN release version X.X.X` and copy this checklist to the issue + +- [ ] Evaluate the status of any failing + [nightly tests and nightly packaging builds](https://lists.apache.org/[email protected]): these are run + against the master branch and not the release branch, so the results may be + slightly out of date. After the CRAN-specific release branch has been created, + we can run any or all tests again using a GitHub PR and crossbow. Review Comment: I'm confused by this step - is this a new additional step? It's not release verification, as that's something else. Kou later made https://github.com/apache/arrow/pull/14654 which basically does everything we need to do in this step. We need more info here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
