alamb commented on issue #4248: URL: https://github.com/apache/arrow-datafusion/issues/4248#issuecomment-1331057196
> datafusion-cli wasn't that easy to use as a library without [Command](https://doc.rust-lang.org/std/process/struct.Command.html) wizardry so I resorted to datafusion-core functions with format_batches and run_query at the bottom of this [file](https://github.com/apache/arrow-datafusion/blob/96bd42e0d5879470dc71281c297eb103115ca300/tests/sqllogictests/src/main.rs) I think hooking it up as you have it is the right way to go. We can look into testing datafusion-cli specific stuff as a follow on project > sqllogictests can not test the output column names (that are currently testing in integration tests) I think perhaps we could leave a few high level rust `#test` style tests for validating the column names and move the rest over > still figuring out a few TODOS in the aggregate.slt file 👍 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
