wjones127 commented on PR #14679: URL: https://github.com/apache/arrow/pull/14679#issuecomment-1331102409
> I tried running this locally, but I don't think both `na` and `null_strings` have been hooked up to the same thing, as when I supply the `na` argument instead of `null_strings` I get: > > ``` > Error in `check_additional_args()` at r/R/dataset-format.R:442:6: > ! `na` is not a valid argument for your chosen `format`. > ℹ Supported arguments: `include_header`, `batch_size`, and `null_string`. > ``` Ah yes. As written, this enables `na` in `write_csv_arrow()` and `null_string` in `write_dataset()`, but not the other way around. I can update so each function supports both. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
