liukun4515 commented on code in PR #4400:
URL: https://github.com/apache/arrow-datafusion/pull/4400#discussion_r1035492782
##########
datafusion/sql/src/planner.rs:
##########
@@ -3213,7 +3213,7 @@ mod tests {
let sql = "SELECT CAST(10 AS DECIMAL(0))";
let err = logical_plan(sql).expect_err("query should have failed");
assert_eq!(
- r##"Internal("Decimal(precision = 0, scale = 0) should satisty
`0 < precision <= 38`, and `scale <= precision`.")"##,
+ r##"Internal("Decimal(precision = 0, scale = 0) should satisfy
`-38 < precision <= 38`, and `scale <= precision`.")"##,
Review Comment:
I'am confused about the error message.
The origin message is more reasonable for me, and the precision should be
`precision>0 and precision<=38` in the datafusion.
cc @alamb @tustvold
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
