mingmwang commented on PR #4365:
URL:
https://github.com/apache/arrow-datafusion/pull/4365#issuecomment-1331618851
Could you please also modify the UT `optimize_plan()` method and let the
rule run twice and see what will happen ?
```
fn optimize_plan(plan: &LogicalPlan) -> LogicalPlan {
let rule = FilterPushDown::new();
rule.optimize(plan, &mut OptimizerConfig::new())
.expect("failed to optimize plan")
}
```
I think some of the logic in the rule like 'extract_or_clauses_for_join()' a
reasonable optimization, but if the optimizer rules were applied more than
once that duplicate Filters might be generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
