pitrou commented on code in PR #14742:
URL: https://github.com/apache/arrow/pull/14742#discussion_r1035769461
##########
cpp/src/parquet/metadata.h:
##########
@@ -118,6 +119,12 @@ struct PageEncodingStats {
int32_t count;
};
+/// \brief Public struct for location to page index in ColumnChunkMetaData.
+struct IndexLocation {
+ int64_t index_file_offset_bytes;
+ int32_t offset_index_length;
Review Comment:
I'm not sure why the complex naming, we could just have
```suggestion
/// File offset of the given index, in bytes
int64_t offset;
/// Length of the given index, in bytes
int32_t length;
```
##########
cpp/src/parquet/metadata.cc:
##########
@@ -312,6 +312,20 @@ class ColumnChunkMetaData::ColumnChunkMetaDataImpl {
}
}
+ inline std::optional<IndexLocation> GetColumIndexLocation() const {
Review Comment:
`inline` is implied if the method is defined inside the `class` body, so
it's superfluous here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
