ygf11 commented on issue #4389: URL: https://github.com/apache/arrow-datafusion/issues/4389#issuecomment-1333032382
> cc @ygf11 we should make the equal join condition to Option, there is https://github.com/apache/arrow-datafusion/issues/4363 for join. Currently the planner will convert `join` to `cross join` when `equal Join condition` is empty. I guess the reason is that we do not have a Physical Plan(e.g. `Nested-loop-join`) to handle join whose equal Join condition is empty. So If we add the implementation of `Nested-loop-join`, I think the bug will be fixed. https://github.com/apache/arrow-datafusion/blob/3fe542f2afcd5360edc9abb7ad1e8243b560a6b2/datafusion/sql/src/planner.rs#L769-L776 I also have the same confuse of empty list and `None<Vec<_>>`, I think `Vec` is enough, can you please explain more? @liukun4515 @mingmwang -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
