mustafasrepo commented on PR #4439: URL: https://github.com/apache/arrow-datafusion/pull/4439#issuecomment-1333468692
> No, I think this change is not correct!!! WindowAggExec should always keep the input ordering, and the input ordering does not always equal with the required input ordering. For example, input ordering could be `order by ['a', 'b', 'c']`, the required input ordering is `order by ['a', 'b']`, `order by ['a', 'b', 'c']` can satisfy `order by ['a', 'b']`, in this case, the output ordering of the WindowAggExec itself is still `order by ['a', 'b', 'c']`. We have updated this PR to address this concern. Thanks for pointing it out @mingmwang . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
