amol- commented on code in PR #14369:
URL: https://github.com/apache/arrow/pull/14369#discussion_r1037062147


##########
python/pyarrow/array.pxi:
##########
@@ -1402,6 +1402,22 @@ cdef class Array(_PandasConvertible):
         """
         return _pc().index(self, value, start, end, memory_pool=memory_pool)
 
+    def sort(self, order="ascending"):

Review Comment:
   Added support for `SortOptions`, so `null_placement` can be provided and it 
will also be future proof to any option added in the future. See 
https://github.com/apache/arrow/pull/14781



##########
python/pyarrow/array.pxi:
##########
@@ -2746,6 +2762,29 @@ cdef class StructArray(Array):
         result.validate()
         return result
 
+    def sort(self, order="ascending", fieldname=None):
+        """
+        Sort the StructArray
+
+        Parameters
+        ----------
+        order : "ascending" or "descending"
+            The order of the sorting.

Review Comment:
   Changed as suggested. See https://github.com/apache/arrow/pull/14781



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to