martin-g commented on PR #93: URL: https://github.com/apache/arrow-datafusion-python/pull/93#issuecomment-1334045463
The same config is used for the CI build workflow so it should fail on master too. On Thu, Dec 1, 2022, 18:02 Andy Grove ***@***.***> wrote: > ***@***.**** commented on this pull request. > ------------------------------ > > In pyproject.toml > <https://github.com/apache/arrow-datafusion-python/pull/93#discussion_r1037297490> > : > > > @@ -55,4 +55,9 @@ repository = "https://github.com/apache/arrow-datafusion-python"; > profile = "black" > > [tool.maturin] > -sdist-include = ["Cargo.lock"] > +include = [ > + { path = "Cargo.lock", format = "sdist" } > +] > +exclude = [".github/**", "ci/**", ".asf.yaml"] > +# Require Cargo.lock is up to date > +locked = true > > Will this fail the build if Cargo.lock is not up-to-date? This action > doesn't run until we tag the release candidate so there is a good chance > this will fail unless we also have a CI check on PRs to make sure > Cargo.lock is up-to-date? > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/arrow-datafusion-python/pull/93#pullrequestreview-1201272179>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AABYUQVPR4Z4N24XXYXW3EDWLDDZBANCNFSM6AAAAAASQS6QGU> > . > You are receiving this because you authored the thread.Message ID: > ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
