kylebarron commented on code in PR #13076:
URL: https://github.com/apache/arrow/pull/13076#discussion_r1037457502
##########
js/src/ipc/reader.ts:
##########
@@ -352,12 +353,24 @@ abstract class RecordBatchReaderImpl<T extends TypeMap =
any> implements RecordB
return this;
}
- protected _loadRecordBatch(header: metadata.RecordBatch, body: any) {
+ protected _loadRecordBatch(header: metadata.RecordBatch, body: Uint8Array)
{
+ if (header.compression) {
+ const codec = compressionRegistry.get(header.compression);
+ if (codec?.decode) {
+ // TODO: does this need to be offset by 8 bytes? Since the
uncompressed length is
+ // written in the first 8 bytes:
+ //
https://github.com/apache/arrow/blob/1fc251f18d5b48f0c9fe8af8168237e7e6d05a45/format/Message.fbs#L59-L65
Review Comment:
Thanks for doing some digging! This PR isn't currently at the top of my list
of things to work on, but would love for this support to be added to arrow JS!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
