alamb commented on code in PR #4467:
URL: https://github.com/apache/arrow-datafusion/pull/4467#discussion_r1037481333
##########
datafusion/core/src/physical_plan/file_format/mod.rs:
##########
@@ -796,4 +808,38 @@ mod tests {
output_ordering: None,
}
}
+
+ #[test]
+ fn file_groups_display_empty() {
+ let expected = "";
+ assert_eq!(&FileGroupsDisplay(&vec![]).to_string(), expected);
+ }
+
+ #[test]
+ fn file_groups_display() {
+ let files = vec![
+ vec![partitioned_file("foo"), partitioned_file("bar")],
+ vec![partitioned_file("baz")],
+ vec![],
+ ];
+
+ let expected = "group 0: [foo, bar], group 1: [baz], group 2: []";
Review Comment:
Prior to the changes in this PR, this was displayed as `"[foo, bar, baz, ]"`
I think this PR is much clearer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
