kou commented on PR #14585: URL: https://github.com/apache/arrow/pull/14585#issuecomment-1334324641
It seems there are still CMake lint errors: https://github.com/apache/arrow/actions/runs/3591159963/jobs/6045602036#step:5:815 ```text INFO:archery:Running cmake-format linters ERROR __main__.py:618: Check failed: /arrow/cpp/cmake_modules/DefineOptions.cmake ERROR __main__.py:618: Check failed: /arrow/cpp/CMakeLists.txt ERROR __main__.py:618: Check failed: /arrow/cpp/cmake_modules/FindQPL.cmake ERROR __main__.py:618: Check failed: /arrow/cpp/cmake_modules/ThirdpartyToolchain.cmake ``` Could you confirm them? https://arrow.apache.org/docs/developers/cpp/development.html#code-style-linting-and-ci > CMake files pass style checks, can be fixed by running `archery lint --cmake-format --fix`. This requires Python 3 and [cmake_format](https://github.com/cheshirekow/cmake_format) (note: this currently does not work on Windows). FYI: You can check lint result in your fork too: https://github.com/yaqi-zhao/arrow/actions/runs/3591159610/jobs/6045360960#step:5:4197 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
