alamb commented on code in PR #4472:
URL: https://github.com/apache/arrow-datafusion/pull/4472#discussion_r1037612827
##########
datafusion/core/tests/sqllogictests/src/main.rs:
##########
@@ -29,53 +29,18 @@ mod setup;
mod utils;
const TEST_DIRECTORY: &str = "tests/sqllogictests/test_files";
-const TEST_CATEGORIES: [TestCategory; 2] =
- [TestCategory::Aggregate, TestCategory::ArrowTypeOf];
-
-pub enum TestCategory {
- Aggregate,
- ArrowTypeOf,
-}
-
-impl TestCategory {
- fn as_str(&self) -> &'static str {
- match self {
- TestCategory::Aggregate => "Aggregate",
- TestCategory::ArrowTypeOf => "ArrowTypeOf",
- }
- }
-
- fn test_filename(&self) -> &'static str {
- match self {
- TestCategory::Aggregate => "aggregate.slt",
Review Comment:
Rather than hard coding this list, I propose instead listing the files in
the directory instead
##########
datafusion/core/tests/sql/information_schema.rs:
##########
@@ -669,98 +669,3 @@ async fn show_external_create_table() {
async fn plan_and_collect(ctx: &SessionContext, sql: &str) ->
Result<Vec<RecordBatch>> {
ctx.sql(sql).await?.collect().await
}
-
-#[tokio::test]
-async fn show_variable_in_config_options() {
- let ctx =
-
SessionContext::with_config(SessionConfig::new().with_information_schema(true));
- let sql = "SHOW datafusion.execution.batch_size";
- let results = plan_and_collect(&ctx, sql).await.unwrap();
-
- let expected = vec![
- "+---------------------------------+---------+",
- "| name | setting |",
- "+---------------------------------+---------+",
- "| datafusion.execution.batch_size | 8192 |",
- "+---------------------------------+---------+",
- ];
-
- assert_batches_eq!(expected, &results);
-}
-
-#[tokio::test]
-async fn show_all() {
Review Comment:
moved to a data file rather than .rs file 🎉
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
