jorisvandenbossche commented on code in PR #14781:
URL: https://github.com/apache/arrow/pull/14781#discussion_r1037878514


##########
python/pyarrow/array.pxi:
##########
@@ -1399,6 +1399,29 @@ cdef class Array(_PandasConvertible):
         """
         return _pc().index(self, value, start, end, memory_pool=memory_pool)
 
+    def sort(self, order="ascending", **options):
+        """
+        Sort the Array
+
+        Parameters
+        ----------
+        order : str, default "ascending"
+            Which order to sort values in.
+            Accepted values are "ascending", "descending".
+        **options : dict, optional
+            Additional sorting options
+            As allowed by :class:`SortOptions`

Review Comment:
   Good idea to just pass through options, that automatically also allows to 
use `null_placement`.
   
   I know this are indeed options, but for consistency I would suggest to use 
`**kwargs`. For example Array.sum also uses kwargs to pass through options.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to