Ted-Jiang commented on code in PR #4485:
URL: https://github.com/apache/arrow-datafusion/pull/4485#discussion_r1037980683
##########
datafusion/proto/src/from_proto.rs:
##########
@@ -806,11 +806,20 @@ pub fn parse_expr(
.ok_or_else(|| Error::unknown("BuiltInWindowFunction",
*i))?
.into();
+ let args = match parse_optional_expr(&expr.expr,
registry)? {
+ None => {
+ vec![]
+ }
+ Some(x) => {
+ vec![x]
+ }
+ };
+
Ok(Expr::WindowFunction {
fun:
datafusion_expr::window_function::WindowFunction::BuiltInWindowFunction(
built_in_function,
),
- args: vec![parse_required_expr(&expr.expr, registry,
"expr")?],
Review Comment:
Unlike WindowFunction with `AggrFunction` like `min(col)`. `max(col)`.
`sum(col)` it must have required_exp
Built-in WindowFunction like `ROW_NUMBER()` . `RANK()`. `DENSE()` have to
have this value
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
