amol- commented on code in PR #14781:
URL: https://github.com/apache/arrow/pull/14781#discussion_r1038143786


##########
python/pyarrow/array.pxi:
##########
@@ -1399,6 +1399,29 @@ cdef class Array(_PandasConvertible):
         """
         return _pc().index(self, value, start, end, memory_pool=memory_pool)
 
+    def sort(self, order="ascending", **options):
+        """
+        Sort the Array
+
+        Parameters
+        ----------
+        order : str, default "ascending"
+            Which order to sort values in.
+            Accepted values are "ascending", "descending".
+        **options : dict, optional
+            Additional sorting options
+            As allowed by :class:`SortOptions`

Review Comment:
   Will rename to `kwargs`, regarding the `dict` type, that's what the numpydoc 
documentation suggests -> 
https://numpydoc.readthedocs.io/en/latest/format.html#parameters
   
   > When documenting variable length positional, or keyword arguments, leave 
the leading star(s) in front of the name:
   > ```
   > *args : tuple
   >     Additional arguments should be passed as keyword arguments
   > **kwargs : dict, optional
   >     Extra arguments to `metric`: refer to each metric documentation for a
   >     list of all possible arguments.
   > ```
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to