alamb commented on code in PR #4469: URL: https://github.com/apache/arrow-datafusion/pull/4469#discussion_r1038178896
########## docs/source/contributor-guide/index.md: ########## @@ -134,6 +134,10 @@ cargo test -p datafusion --tests sql_integration One very important test is the [sql_integration](../../../datafusion/core/tests/sql_integration.rs) test which validates DataFusion's ability to run a large assortment of SQL queries against an assortment of data setups. +### sqllogictests Tests + +The [sqllogictests](../../../datafusion/core/tests/sqllogictests) also validate DataFusion SQL against an assortment of data setups. Review Comment: ```suggestion The [sqllogictests](../../../datafusion/core/tests/sqllogictests) also validate DataFusion SQL against an assortment of data setups. Data Driven tests have many benefits including being easier to write and maintain. We are in the process of [migrating sql_integration tests](https://github.com/apache/arrow-datafusion/issues/4460) and encourage you to add new tests using sqllogictests if possible. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
