rok commented on code in PR #14191:
URL: https://github.com/apache/arrow/pull/14191#discussion_r1038490687
##########
cpp/src/parquet/column_writer_test.cc:
##########
@@ -418,23 +419,29 @@ TYPED_TEST(TestPrimitiveWriter, RequiredRLE) {
TYPED_TEST(TestPrimitiveWriter, RequiredBitPacked) {
this->TestRequiredWithEncoding(Encoding::BIT_PACKED);
}
+*/
+
+TEST_F(TestValuesWriterInt32Type, RequiredDeltaBinaryPacked) {
+ this->TestRequiredWithEncoding(Encoding::DELTA_BINARY_PACKED);
+}
-TYPED_TEST(TestPrimitiveWriter, RequiredDeltaBinaryPacked) {
+TEST_F(TestValuesWriterInt64Type, RequiredDeltaBinaryPacked) {
this->TestRequiredWithEncoding(Encoding::DELTA_BINARY_PACKED);
}
Review Comment:
> Should we add a roundtrip test in the arrow_reader_writer_test.cc file to
make sure this is covered?
@wgtmac I don't see where (and if) arrow_reader_writer_test.cc tests
encodings. I've enabled this test as this is probably what you're suggesting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
