xudong963 commented on code in PR #4496: URL: https://github.com/apache/arrow-datafusion/pull/4496#discussion_r1038967801
########## datafusion/core/tests/sqllogictests/src/error.rs: ########## @@ -0,0 +1,83 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +use datafusion_common::DataFusionError; +use sqllogictest::TestError; +use sqlparser::parser::ParserError; +use std::error; +use std::fmt::{Display, Formatter}; + +pub type Result<T> = std::result::Result<T, DFSqlLogicTestError>; + +/// DataFusion sql-logicaltest error +#[derive(Debug)] +pub enum DFSqlLogicTestError { + /// Error from sqllogictest-rs + SqlLogicTest(TestError), + /// Error from datafusion + DataFusion(DataFusionError), + /// Error returned when SQL is syntactically incorrect. + Sql(ParserError), + /// Error returned on a branch that we know it is possible + /// but to which we still have no implementation for. + /// Often, these errors are tracked in our issue tracker. + NotImplemented(String), + /// Error returned from DFSqlLogicTest inner + Internal(String), Review Comment: LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
