wgtmac commented on PR #14351: URL: https://github.com/apache/arrow/pull/14351#issuecomment-1336409467
> @pitrou Hi, I tried to add some unittest and pass the tests. > > Now I generate some files from https://github.com/apache/parquet-mr/blob/master/parquet-hadoop/src/test/java/org/apache/parquet/hadoop/TestDataPageV1Checksums.java , should I first commit them to `parquet-test` project, and then testing them in C++? > > By the way, I'm not familiar with parquet-mr, where does it testing `parquet-test`? If it has some parquet crc testing, I can just follow it. /cc @wgtmac I agree that we can add some test files generated by arrow and parquet-mr to parquet-testing submodule. And then add inter-op tests in both arrow and parquet-mr repos to do cross validation. FYI, I have added inter-op test for LZ4_RAW to parquet-mr: https://github.com/apache/parquet-mr/blob/master/parquet-hadoop/src/test/java/org/apache/parquet/hadoop/codec/TestInteropReadLz4RawCodec.java -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
