Ted-Jiang commented on code in PR #4511:
URL: https://github.com/apache/arrow-datafusion/pull/4511#discussion_r1039290812
##########
datafusion/physical-expr/src/expressions/mod.rs:
##########
@@ -62,9 +62,12 @@ pub use crate::aggregate::sum_distinct::DistinctSum;
pub use crate::aggregate::variance::{Variance, VariancePop};
pub use crate::window::cume_dist::cume_dist;
+pub use crate::window::cume_dist::CumeDist;
+pub use crate::window::lead_lag::WindowShift;
pub use crate::window::lead_lag::{lag, lead};
-pub use crate::window::nth_value::NthValue;
+pub use crate::window::nth_value::{NthValue, NthValueKind};
Review Comment:
Although the struct is public, but the mod is private. So i decide public
less, only the needed struct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
