andre-cc-natzka commented on PR #4312: URL: https://github.com/apache/arrow-datafusion/pull/4312#issuecomment-1336990762
Hello @waitingkuo, @alamb. Thanks for your feedback! It's been a long time, I apologize for that. I took some days of vacation actually. I am also sorry for the state of this PR, I should indeed have rebased master in advance. I have been through the process now and I believe the problems pointed out by @waitingkuo have been solved. In fact, the changes I implemented here are very simple, and are limited to the ones in [datafusion/expr/src/type_coercion/binary.rs](https://github.com/apache/arrow-datafusion/pull/4312/files#diff-6a1eb5571196f1bd9f3defbbd97ed99e0e527e4ede426ce7e802ab949f1c431e), which aim at enabling type coercion to a timestamp (to nanosecond accuracy, since it is the only one supported by Arrow) when a string and a timestamp (with arbitrary precision) are provided. This could be very useful in my opinion. Thank you again, André. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
