paleolimbot commented on issue #67: URL: https://github.com/apache/arrow-nanoarrow/issues/67#issuecomment-1337471166
Is there anything I should add to the checklist in #71? I believe the "creating from buffers" and "manually creating schemas" are the two main things that are missing and I will add them before the release. Because of the nature of an "Apache Release", which has a very specific definition, I have to implement a bunch of stuff in the C library and expand its test coverage a bit before I can make an official "nanoarrow" CRAN release. In your example, I believe that you are missing `ArrowArrayStartAppending()` and `ArrowArayFinishBuilding()`. Also note that all of these may return something other than `NANOARROW_OK` (i.e., zero) which would indicate a failure (normally a failed allocation). You can use the `NANOARROW_RETURN_NOT_OK()` macro to keep that from becoming unreadable. There's an example with this in the examples/ directory: https://github.com/apache/arrow-nanoarrow/blob/main/examples/vendored-minimal/src/library.c#L31-L47 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
