jorgecarleitao commented on pull request #8481: URL: https://github.com/apache/arrow/pull/8481#issuecomment-712584694
We are already force-pushing to master on every release, which goes against best practices of an open-source project. AFAIK, in open source, there is a strong expectation that PRs are managed by individual contributors, and committers of the project only request contributors to make changes to them, or kindly ask before pushing (not force-pushing) directly to the PR. We are inverting all expectations and _force-pushing_ to PRs(!!). Furthermore, those force-pushes actually break the PRs (as you can see above). IMO this drives any reasonable contributor to be pissed off at the team for what they just did: * force-pushing to master * force-pushing to their PRs * breaking their PRs's CI * no prior notice or request of any of the above I suggest that we: 1. stop force-pushing to PRs 2. stop pushing to PRs without the contributor's explicit consent 3. document in [the contributing guidelines](https://github.com/apache/arrow/blob/master/.github/CONTRIBUTING.md) that master is force-pushed on every release, and the steps that folks need to take to bring their PRs to the latest master. In general, it is the contributor's responsibility to keep the PRs in a "ready to merge" state, rebasing them to master as master changes. IMO a force-push to master corresponds to a change in master, and thus it is the contributor's responsibility to rebase their PRs against the new master. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
