Fuuzetsu commented on PR #3277: URL: https://github.com/apache/arrow-rs/pull/3277#issuecomment-1338576102
@viirya @tustvold Did you check that this actually does anything? The way that cargo resolution works, this change has no impact: https://github.com/rust-lang/cargo/issues/1197 https://github.com/tkaitchuck/aHash/issues/140 Even if you put a feature behind a `target` that we're not compiling for, it _will_ get included. Therefore as long as `ahash` is in the tree and `compile-time-rng` is specified for any of the targets, it `const-random` will be pulled in. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
