pitrou opened a new pull request #8493: URL: https://github.com/apache/arrow/pull/8493
Hide more implementation details from `parser.h`. Interestingly, this increases performance on the CSV parser micro-benchmarks (at least here with clang 10.0 on Ubuntu 20.04). * before: ``` ------------------------------------------------------------------------------- Benchmark Time CPU Iterations UserCounters... ------------------------------------------------------------------------------- ParseCSVQuotedBlock 95316 ns 95299 ns 29615 bytes_per_second=655.817M/s ParseCSVEscapedBlock 93352 ns 93339 ns 30059 bytes_per_second=630.202M/s ``` * after: ``` ParseCSVQuotedBlock 75507 ns 75497 ns 37173 bytes_per_second=827.833M/s ParseCSVEscapedBlock 70170 ns 70157 ns 43528 bytes_per_second=838.448M/s ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
