waitingkuo commented on PR #4312:
URL:
https://github.com/apache/arrow-datafusion/pull/4312#issuecomment-1338929873
hi @andre-cc-natzka thank you, it looks good to me.
I suggest that add some SQL level tests
e.g.
```bash
❯ select (timestamp '2000-01-01T00:00:00') = '2000-01-01T00:00:00';
+-----------------------------------------------------------+
| Utf8("2000-01-01T00:00:00") = Utf8("2000-01-01T00:00:00") |
+-----------------------------------------------------------+
| true |
+-----------------------------------------------------------+
1 row in set. Query took 0.002 seconds.
```
and this should raise error until we could cast TimestampTz to Utf8
```bash
❯ select (timestamptz '2000-01-01T00:00:00+00:00') =
'2000-01-01T00:00:00+08:00';
NotImplemented("Unsupported CAST from Utf8 to Timestamp(Nanosecond,
Some(\"+00:00\"))")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
