jorisvandenbossche commented on code in PR #14717:
URL: https://github.com/apache/arrow/pull/14717#discussion_r1040740642
##########
python/pyarrow/tests/parquet/test_parquet_file.py:
##########
@@ -329,3 +334,22 @@ def test_parquet_file_explicitly_closed(tempdir):
p.read()
assert not p.closed
assert p.closed # parquet file obj reports as closed
+
+
[email protected]
+def test_parquet_file_with_filesystem(tempdir, s3_example_s3fs):
Review Comment:
One more question: would it be easy to use `s3_example_fs` instead of
`s3_example_s3fs`? (ideally for simple tests we use as much as possible our own
filesystem so the test doesn't require an external s3fs dependency)
##########
python/pyarrow/tests/parquet/test_parquet_file.py:
##########
@@ -329,3 +334,22 @@ def test_parquet_file_explicitly_closed(tempdir):
p.read()
assert not p.closed
assert p.closed # parquet file obj reports as closed
+
+
[email protected]
+def test_parquet_file_with_filesystem(tempdir, s3_example_s3fs):
+ s3_fs, s3_path = s3_example_s3fs
+
+ table = pa.table({"a": range(10)})
+ pq.write_table(table, s3_path, filesystem=s3_fs)
+
+ parquet_file = pq.ParquetFile(s3_path, filesystem=s3_fs)
Review Comment:
Could you also test `pq.ParquetFile(s3_uri)` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
