rtpsw commented on PR #14352: URL: https://github.com/apache/arrow/pull/14352#issuecomment-1339084819
> > AFAIU, aggregating tables is a valid use case that should be supported. @westonpace, let me know your thoughts. > > Aggregation of tables should be done by using a table source node and an exec plan. Not by using the `GroupBy` function in `aggregate.h`. That was the intent behind the comment: > > ``` > /// Internal use only: helpers for PyArrow and testing HashAggregateKernels. > /// For public use see arrow::compute::Grouper or create an execution plan > /// and use an aggregate node. > ``` IIUC, support of chunked arrays is needed only for `GroupBy` as a testing facility (and that this is [the case with hash aggregation](https://github.com/apache/arrow/pull/14352/#issuecomment-1328279070) too), right? So, if we remove this support, some current testing using `GroupBy` would break and would need to be removed too. @westonpace, are you fine with this outcome? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
