rtpsw commented on code in PR #14799:
URL: https://github.com/apache/arrow/pull/14799#discussion_r1040930819
##########
cpp/src/arrow/engine/substrait/options.h:
##########
@@ -65,16 +69,27 @@ using NamedTableProvider =
std::function<Result<compute::Declaration>(const
std::vector<std::string>&)>;
static NamedTableProvider kDefaultNamedTableProvider;
+class ARROW_ENGINE_EXPORT ExtensionProvider {
+ public:
+ static std::shared_ptr<ExtensionProvider> kDefaultExtensionProvider;
+ virtual ~ExtensionProvider() = default;
+ virtual Result<RelationInfo> MakeRel(std::vector<DeclarationInfo> inputs,
+ const google::protobuf::Any& rel,
Review Comment:
I used a virtual interface, as in `ExecNodeOptions`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
